Skip to content

fix: app sign in with button to open app - #7259

Merged
mergify[bot] merged 2 commits into
mainfrom
truman/fix-app-sign-in
Aug 24, 2026
Merged

fix: app sign in with button to open app#7259
mergify[bot] merged 2 commits into
mainfrom
truman/fix-app-sign-in

Conversation

@tdgao

@tdgao tdgao commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Sometimes the browser prompt to allow modrinth to open the app does not show up on Brave, Edge, or Safari.

This adds a button to try to open app again which should force browser to show that prompt to allow opening in app.

image

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@github-actions

Copy link
Copy Markdown
Contributor

@tdgao
tdgao requested a review from a team August 23, 2026 17:42

@IMB11 IMB11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IMB11

IMB11 commented Aug 24, 2026

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Aug 24, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 14 minutes 30 seconds in the queue, including 12 minutes 52 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Aug 24, 2026
@mergify
mergify Bot merged commit aed00aa into main Aug 24, 2026
11 of 12 checks passed
@mergify
mergify Bot deleted the truman/fix-app-sign-in branch August 24, 2026 16:57
@mergify mergify Bot removed the queued label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants